From 09d9c9e7d8d30c7f718837a44cabc90142f85b3e Mon Sep 17 00:00:00 2001 From: Andreas Grois Date: Wed, 26 Oct 2022 21:39:52 +0200 Subject: Minor, remove a pointless type conversion. Seems not to have any performance impact, but still, cleaner this way. --- src/passwordmaker/base_conversion/iterative_conversion_impl/mod.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/passwordmaker/base_conversion/iterative_conversion_impl/mod.rs b/src/passwordmaker/base_conversion/iterative_conversion_impl/mod.rs index d3e0045..cee5418 100644 --- a/src/passwordmaker/base_conversion/iterative_conversion_impl/mod.rs +++ b/src/passwordmaker/base_conversion/iterative_conversion_impl/mod.rs @@ -371,7 +371,7 @@ impl ArbitraryBytes{ let m_extra_digits_dividend = m_plus_n_digits_dividend - n_digits_divisor; //step D1: Normalize. This brings the maximum error for each digit down to no more than 2. - let normalize_shift = divisor.get_digit_from_right(n_digits_divisor - 1).leading_zeros() as usize; + let normalize_shift = divisor.get_digit_from_right(n_digits_divisor - 1).leading_zeros(); //again, missing const generics ruin all the fun. let mut dividend = self.shift_left(normalize_shift); let divisor = divisor.shift_left(normalize_shift); @@ -434,7 +434,7 @@ impl ArbitraryBytes{ self.0[N-i-1] = val; } - fn shift_left(&self, s : usize) -> ::Output + fn shift_left(&self, s : u32) -> ::Output where Self : PadWithAZero> { debug_assert!(s < 32); @@ -445,7 +445,7 @@ impl ArbitraryBytes{ res } - fn shift_right(mut self, s : usize) -> Self { + fn shift_right(mut self, s : u32) -> Self { debug_assert!(s < 32); if s != 0 { let _ = self.0.iter_mut().fold(0u32, |carry, val| { -- cgit v1.2.3